Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ScopeProto to cfg #3816

Merged
merged 28 commits into from
Dec 2, 2020
Merged

replace ScopeProto to cfg #3816

merged 28 commits into from
Dec 2, 2020

Conversation

ouyangyu
Copy link
Contributor

No description provided.

@ouyangyu ouyangyu requested a review from clackhan November 13, 2020 06:59
@oneflow-ci-bot oneflow-ci-bot removed their request for review November 21, 2020 08:18
clackhan
clackhan reviewed Nov 22, 2020
View reviewed changes
Copy link
Contributor

@clackhan clackhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合并一下master，解决一下冲突，注意两个地方：

@oneflow-ci-bot oneflow-ci-bot removed their request for review November 24, 2020 03:50
@oneflow-ci-bot oneflow-ci-bot removed their request for review November 30, 2020 12:49
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 1, 2020 10:07
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 1, 2020 15:08
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 1, 2020 19:13
@oneflow-ci-bot oneflow-ci-bot removed their request for review December 2, 2020 04:45
clackhan and others added 3 commits December 2, 2020 16:56
@clackhan
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …
f0b9d95 
…remove_serialized_in_python_callback

Conflicts:
	oneflow/python/framework/python_callback.py
@clackhan
Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …
bef79ff 
…remove_serialized_in_python_callback
@ouyangyu
Merge branch 'remove_serialized_in_python_callback' of github.com:One…
99f194d 
…flow-Inc/oneflow into dev_replace_py_scopy_proto_to_cfg
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 2, 2020 11:37
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot December 2, 2020 13:44
@oneflow-ci-bot oneflow-ci-bot merged commit 478a21f into master Dec 2, 2020
@oneflow-ci-bot oneflow-ci-bot deleted the dev_replace_py_scopy_proto_to_cfg branch December 2, 2020 16:05
liujuncheng pushed a commit that referenced this pull request Jun 3, 2021
@ouyangyu @clackhan @oneflow-ci-bot
replace ScopeProto to cfg (#3816)
f07cba0 
* replace ScopeProto to cfg

* remove serialized in python callback

* import modules in python_callback.py

* remove str(scope_proto) in AddScopeToStorage

* del outdated callback func in python_callback.py

* fix scope symbol session_id

* fix SetAttrValue

* add todo

Co-authored-by: clackhan <han_binbin@163.com>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Former-commit-id: 478a21f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clackhan clackhan clackhan approved these changes

@lixinqi lixinqi Awaiting requested review from lixinqi

@Flowingsun007 Flowingsun007 Awaiting requested review from Flowingsun007

Assignees
No one assigned
Labels
automerge cfg enhancement refactor tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouyangyu @clackhan @oneflow-ci-bot