Add ImageDecoderRandomCropResizeOp::InferParallelSignature #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixinqi
reviewed
Oct 4, 2020
Comment on lines
113
to
117
| int64_t device_parallel_desc_symbol_id = JUST(scope.GetParallelDescSymbolId(op_conf())); | ||
| OperatorConf host_op_conf = op_conf(); | ||
| host_op_conf.set_device_tag("cpu"); | ||
| int64_t host_parallel_desc_symbol_id = JUST(scope.GetParallelDescSymbolId(host_op_conf)); | ||
| mut_parallel_signature()->set_op_parallel_desc_symbol_id(device_parallel_desc_symbol_id); |
There was a problem hiding this comment.
给scope类加一个scope_proto()，因为scope_proto上直接有host_parallel_desc_symbol_id和device_parallel_desc_symbol_id。
你都不需要在本函数最外层的那个if
There was a problem hiding this comment.
给scope类加一个scope_proto()，因为scope_proto上直接有host_parallel_desc_symbol_id和device_parallel_desc_symbol_id。
你都不需要在本函数最外层的那个if
最外层的if应该还是要有，当这个op是一个cpu op时，和普通op一致，当是gpu时才特殊
lixinqi
approved these changes
Oct 4, 2020
liujuncheng
added a commit
that referenced
this pull request
Oct 5, 2020
* Fused ImageDecoderRandomCropResize * format * fix cpu build * Add comment * dest=>dst * Add comment * Add ImageDecoderRandomCropResizeOp::InferParallelSignature (#3646) * Add ImageDecoderRandomCropResizeOp::InferParallelSignature * Add Scope::scope_proto * refine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.