Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fused ImageDecoderRandomCropResize #3644
Fused ImageDecoderRandomCropResize #3644
Changes from all commits
11f934f
d4ccd01
aee1afa
4aea78e
5d412ea
d166881
7b7d3ae
dd1af8d
be31f64
1327219
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我感觉使用了这个DecodeH2D以后,我们之前CopyH2D regst num 强制 = 2的trick可以去掉了。这样还能优化boxing v2带来的2倍模型显存的开销?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是否也判断下cuda 版本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不需要判断版本,DecodeH2D用于可以直接将数据从cpu解码到gpu的op,类似CopyHD,但是CopyHD是异步的,DecodeH2D可能没有办法异步,为了避免影响CopyHD,单独作为了一种Task类型。只有nvjpeg限制cuda版本
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果需要独立的线程,需要重写这类的TaskNode::IsIndependent()方法。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用的是GPU上的特定线程,不是独立线程,GPU目前应该也不支持独立线程吧