Parallel unit tests (Step 1, refactor existing unit tests) #3632

jackalcooper · 2020-09-30T10:08:18Z

让每个脚本都可以独立运行
将脚本按照官方文档推荐的规范修改 https://docs.python.org/3/library/unittest.html
oneflow 实际上不存在单元测试和集成测试的区别，因为不存在单独跑一个op的测试，op都是在网络中测试的。

jackalcooper · 2020-09-30T13:06:32Z

note:
设置 CUDA_VISIBLE_DEVICES 之后，tf 会卡住，不知道为什么

jackalcooper · 2020-09-30T13:08:51Z

note:
实现并行还需要解决：

让脚本知道当前空闲的是哪一张卡
设置 CUDA_VISIBLE_DEVICES，tf 不卡住

所以这个 PR 先合并对脚本的修改

oneflow/python/framework/unittest.py

…parallel_unit_tests

ci/test/1node_op_test.sh

oneflow/python/test/ops/test_TestDataTypeAttr.py

oneflow/python/test/ops/test_TestDynamicSource.py

* add classes for different test base class * add export * rm old main files * fix * fix class name * check in changes of tests * fix else * fix bugs * fix order * better naming * update ci script * fix import unittest * add --failfast * filter by card num * fix typo * update ci script * dont set CUDA_VISIBLE_DEVICES * use skip unless * add OneGpuTestCase * fix typo * shorter reason * fix class * fix typo * skip test_train_consistent for now * add tearDown * fix setup * rm todo * skip TestImageResize * fix for pure cpu * skip TestImageTargetResize * fix typo * rename * mv demo * rm readme * rename * rename cases * add --verbose * rename * address reviews * fix export * minor fix * fix export * fix skips * more renames * rename * rename class * rm gpu * rename num in scripts * skip resize img * fix sys env * fix dynamic reshape * fix dynamic reshape * fix skip msg * rm num_gpus * address review * address reviews * rm class * update decorator * fix inden * fix typo * replace class with decorator * fix * refine * fix decorator * mv code * add more decorators * add ONEFLOW_TEST_DEVICE_NUM=1 * fix typo * fix typo * fix name * fix skip msg * use decorators in scripts * larger rol for xla ln Co-authored-by: tsai <caishenghang@oneflow.org> Co-authored-by: oneflow-bot <69100618+oneflow-bot@users.noreply.github.com> Former-commit-id: 789e80b

jackalcooper and others added 10 commits September 30, 2020 17:22

add classes for different test base class

028c17d

add export

c4c1878

rm old main files

4cc0763

fix

c5f71d2

fix class name

69fd6da

check in changes of tests

f4cb78a

fix else

3b62a0f

fix bugs

fe65f8e

fix order

135a5b7

better naming

1dfc3be

jackalcooper changed the title ~~Parallel unit tests~~ Parallel unit tests (Step 1, refactor existing unit tests) Sep 30, 2020

update ci script

ddd6e95

jackalcooper marked this pull request as ready for review September 30, 2020 10:46

jackalcooper added the automerge label Sep 30, 2020

jackalcooper and others added 6 commits September 30, 2020 19:11

fix import unittest

2d498d2

add --failfast

39ab00e

filter by card num

82771e4

fix typo

f2b40e1

update ci script

e5c2c67

dont set CUDA_VISIBLE_DEVICES

e3ff0e8

oneflow-ci-bot and others added 6 commits September 30, 2020 21:22

Merge branch 'master' into parallel_unit_tests

2d55bf0

use skip unless

27042ed

add OneGpuTestCase

315531c

fix typo

5a9dc7d

shorter reason

8026b38

fix class

7520922

jackalcooper marked this pull request as draft September 30, 2020 15:34

fix typo

1713403

tsai added 4 commits October 3, 2020 00:45

fix dynamic reshape

df39a8a

fix dynamic reshape

93ca083

fix skip msg

042fa9e

rm num_gpus

297e718

lixinqi reviewed Oct 3, 2020

View reviewed changes

oneflow/python/framework/unittest.py Outdated Show resolved Hide resolved

oneflow/python/framework/unittest.py Show resolved Hide resolved

oneflow/python/framework/unittest.py Outdated Show resolved Hide resolved

tsai added 12 commits October 3, 2020 12:55

address review

3ea9aa7

address reviews

fcb8300

rm class

edd9cef

update decorator

96ae6ff

fix inden

7244df5

fix typo

03a40f0

replace class with decorator

daee672

fix

974b554

refine

7612db3

fix decorator

28a1393

Merge branch 'master' of https://github.com/Oneflow-Inc/oneflow into …

25449af

…parallel_unit_tests

mv code

bb9217c

lixinqi reviewed Oct 3, 2020

View reviewed changes

ci/test/1node_op_test.sh Show resolved Hide resolved

oneflow/python/test/ops/test_TestDataTypeAttr.py Outdated Show resolved Hide resolved

oneflow/python/test/ops/test_TestDynamicSource.py Show resolved Hide resolved

tsai added 7 commits October 3, 2020 23:51

add more decorators

16ab9ec

add ONEFLOW_TEST_DEVICE_NUM=1

730f004

fix typo

dc0eeba

fix typo

c31bce9

fix name

b2c221b

fix skip msg

391e357

use decorators in scripts

cbd9655

lixinqi approved these changes Oct 3, 2020

View reviewed changes

larger rol for xla ln

c9d785d

oneflow-ci-bot merged commit 789e80b into master Oct 3, 2020

oneflow-ci-bot deleted the parallel_unit_tests branch October 3, 2020 18:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parallel unit tests (Step 1, refactor existing unit tests) #3632

Parallel unit tests (Step 1, refactor existing unit tests) #3632

jackalcooper commented Sep 30, 2020 •

edited

Loading

jackalcooper commented Sep 30, 2020

jackalcooper commented Sep 30, 2020

Parallel unit tests (Step 1, refactor existing unit tests) #3632

Parallel unit tests (Step 1, refactor existing unit tests) #3632

Conversation

jackalcooper commented Sep 30, 2020 • edited Loading

jackalcooper commented Sep 30, 2020

jackalcooper commented Sep 30, 2020

jackalcooper commented Sep 30, 2020 •

edited

Loading