Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer oneflow_compile from onediff to oneflow #10404

Closed
wants to merge 17 commits into from
Closed

transfer oneflow_compile from onediff to oneflow #10404

wants to merge 17 commits into from

Conversation

linzs148
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wyg1997 wyg1997 requested a review from strint January 12, 2024 02:17
wyg1997
wyg1997 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@wyg1997 wyg1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyg1997
Copy link
Contributor

wyg1997 commented Jan 12, 2024

代码还有问题，测试本地跑了吗？

@linzs148 linzs148 force-pushed the feat/transfer_oneflow_compile branch 2 times, most recently from bd9e636 to 639e63c Compare January 13, 2024 06:02
@linzs148 linzs148 force-pushed the feat/transfer_oneflow_compile branch from e1aa8ce to 6b9c18d Compare January 15, 2024 05:23
@linzs148 linzs148 force-pushed the feat/transfer_oneflow_compile branch from 67bbaab to 9edc0e8 Compare January 16, 2024 07:02
@levi131 levi131 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 18, 2024 06:25
@linzs148 linzs148 mentioned this pull request Jan 18, 2024
Merged
@wyg1997
Copy link
Contributor

wyg1997 commented Jan 18, 2024

#10408 中重新提交

@wyg1997 wyg1997 closed this Jan 18, 2024
linzs148 added a commit that referenced this pull request Jan 18, 2024
@linzs148 @wyg1997
move onediff.infer_compiler.oneflow_compile to onefow.framework.infer…
2e331e1 
…_compiler.compile_from_torch (#10408)

resubmit for PR #10404

---------

Co-authored-by: Yinggang Wang <wangyinggang@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyg1997 wyg1997 wyg1997 approved these changes

@strint strint Awaiting requested review from strint

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge feature graph graph mode python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linzs148 @CLAassistant @wyg1997 @strint @levi131