feat(#599): expose pendingQuestion in get_status and REST endpoint#600
Merged
OneStepAt4time merged 1 commit intomainfrom Mar 31, 2026
Merged
feat(#599): expose pendingQuestion in get_status and REST endpoint#600OneStepAt4time merged 1 commit intomainfrom
OneStepAt4time merged 1 commit intomainfrom
Conversation
Owner
Author
👁️ Argus Code Reviewfeat(#599): expose pendingQuestion in get_status and REST endpoint Verdict: ✅ Approved — code is solidWhat it doesExposes Checklist
Notes
Ready to merge after rebase. |
58fb45f to
5f17d2a
Compare
When a session enters ask_question state, get_status (MCP) and GET /v1/sessions/:id (REST) now include a pendingQuestion payload with toolUseId, content, options, and since timestamp. This closes the feedback loop for MCP callers that previously had no visibility into CC questions, causing duplicate session spawns. Changes: - session.ts: add timestamp to PendingQuestion, expose in getPendingQuestionInfo() - server.ts: extend addActionHints() with pendingQuestion payload + extractQuestionOptions() - mcp-server.test.ts: add test verifying pendingQuestion flows through get_status Closes #599 (intervention 1 of 3)
5f17d2a to
3e11495
Compare
OneStepAt4time
added a commit
that referenced
this pull request
Mar 31, 2026
## [2.3.0](v2.2.6...v2.3.0) (2026-03-31) ### Features * expose pendingQuestion in get_status and REST endpoint (#600) ### Bug Fixes * ci: use RELEASE_PAT for release-please to trigger CI on PRs (#601)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #599 (intervention 1 of 3).
When a session enters
ask_questionstate,get_status(MCP) andGET /v1/sessions/:id(REST) now include apendingQuestionpayload:{ "status": "ask_question", "pendingQuestion": { "toolUseId": "toolu_abc123", "content": "Which strategy? 1) Clean up 2) Auto-restart 3) Both", "options": ["Clean up", "Auto-restart", "Both"], "since": 1774906529600 } }This closes the feedback loop for MCP callers that previously had no visibility into CC questions — the root cause of duplicate session spawns.
Changes (3 files, +71/-6)
src/session.tstimestamptoPendingQuestion, expose ingetPendingQuestionInfo()src/server.tsaddActionHints()withpendingQuestionpayload +extractQuestionOptions()helpersrc/__tests__/mcp-server.test.tspendingQuestionflows throughget_statusVerification
tsc --noEmit— exit 0npm run build— exit 0npm test— 75 files, 1734 tests passed, 0 failedWhat is NOT in this PR
Interventions 2 and 3 from #599 (
waitForStableoncreate_sessionand idempotency key) will be separate PRs.