fix: SSRF protection for webhook URLs and screenshot fetch — Issue #346#379
Merged
OneStepAt4time merged 4 commits intomainfrom Mar 27, 2026
Merged
fix: SSRF protection for webhook URLs and screenshot fetch — Issue #346#379OneStepAt4time merged 4 commits intomainfrom
OneStepAt4time merged 4 commits intomainfrom
Conversation
Shared module with isPrivateIP (RFC 1918, loopback, link-local, CGNAT), validateWebhookUrl (HTTPS enforcement, localhost dev mode), and resolveAndCheckIp (DNS resolution with DI for testability). Generated by Hephaestus (Aegis dev agent)
Generated by Hephaestus (Aegis dev agent)
#346 Rejects non-HTTPS, private IPs, and localhost in webhook URLs. Accepts HTTP only for 127.0.0.1 dev mode. Generated by Hephaestus (Aegis dev agent)
…check — Issue #346 Replaces inline validateScreenshotUrl in server.ts with shared module. Adds post-DNS-resolution IP check to screenshot routes. Generated by Hephaestus (Aegis dev agent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #346
Changes (7 files, +633/-49)
1047 tests passing.