Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add namespace to build.gradle for react-native 0.73+ #1526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szymonrybczak
Copy link

@szymonrybczak szymonrybczak commented Jun 19, 2023

Description

One Line Summary

This is a change that'll be required starting from React Native 0.73.x. More context can be found here: react-native-community/discussions-and-proposals#671

Testing

Manual testing

Run the example app on android, everything should work fine ✅


This change is Reviewable

@nan-li
Copy link
Contributor

nan-li commented Jun 26, 2023

Hi @szymonrybczak,

Thank you so much for bringing this to our attention.
It looks like there are some other updates around AGP and Java versions. We will have to test and ensure backwards compatibility.

@nan-li nan-li self-assigned this Jun 26, 2023
@burakkgunduzz
Copy link

any updates here since 31 of August was the last day for new updates? And without this change we cannot build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants