fix: add missing configuration accessors for api keys#58
Open
duongvanlong wants to merge 1 commit intoOneSignal:mainfrom
Open
fix: add missing configuration accessors for api keys#58duongvanlong wants to merge 1 commit intoOneSignal:mainfrom
duongvanlong wants to merge 1 commit intoOneSignal:mainfrom
Conversation
Fixes NoMethodError when configuring organization_api_key and rest_api_key. These keys are required for authentication but were missing from the Configuration class. Changes: - Add attr_accessor for organization_api_key and rest_api_key in configuration.rb - Add specs to verify these keys can be configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: add missing configuration accessors for api keys
Details
Motivation
Fixes NoMethodError when configuring organization_api_key and rest_api_key. These keys are required for authentication but were missing from the Configuration class.
Scope
Testing
Manual testing
Checklist
Overview
Testing
Final pass