Fix notification_types type of SubscriptionObject model #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating
SubscriptionObject
withnotification_types
value set (1, -31, etc) for theupdate_subscription
fails withonesignal.exceptions.ApiTypeError: Invalid type for variable 'notification_types'. Required value type is float and passed type was int at ['notification_types']
.Details
Motivation
OneSignal API requires
notification_types
object ofSubscriptionObject
to be of typeint
and fails otherwise with{"errors":[{"title":"Field notification_types was expecting value of type 'int32', received value of type 'number 1.0' instead"}]}
Scope
notification_types
type of SDK matches the type in the API.The workaround could be to omit type check on the model creation step:
Testing
Manual testing
fails with the following:
Using floats with
notification_types=1.0 if enabled else -31.0,
instead fails on the API side with#46