[Bug]: RestSharp constructor not found

[rer145]

What happened?

Version 1.0.1 of the OneSignalApi throws an exception when sending a notification because it can't find a constructor in the RestSharp package.

Message: Method not found: 'Void RestSharp.RestRequest..ctor(RestSharp.Method)'.

StackTrace:
System.MissingMethodException: Method not found: 'Void RestSharp.RestRequest..ctor(RestSharp.Method)'.\r\n at OneSignalApi.Client.ApiClient.NewRequest(HttpMethod method, String path, RequestOptions options, IReadableConfiguration configuration)\r\n at OneSignalApi.Client.ApiClient.Post[T](String path, RequestOptions options, IReadableConfiguration configuration)\r\n at OneSignalApi.Api.DefaultApi.CreateNotificationWithHttpInfo(Notification notification, Int32 operationIndex)\r\n at OneSignalApi.Api.DefaultApi.CreateNotification(Notification notification, Int32 operationIndex)\r\n

Using RestSharp 108.0.1, I don't see a constructor in their code that matches the pattern of just taking in a Method.

I'm mixing a .NET Framework API with a .NET Standard Class Library, and the required packages are installed in both projects.

Code Snippet (inside the .NET Standard Class Library, called from the .NET Framework API):

var restApiKey = "......";
var Configuration = new OneSignalApi.Client.Configuration();
Configuration.BasePath = "https://onesignal.com/api/v1";
Configuration.AccessToken = restApiKey;
Configuration.ApiKey.Add("default", restApiKey);

var model = new OneSignalApi.Model.Notification(appId: AppId)
 {
    IncludeExternalUserIds = new List<string> { "..." },
    Name = "Test Message",
    ChannelForExternalUserIds = "push"
};

model.Contents = new OneSignalApi.Model.StringMap { En = "message contents" };

var api = new DefaultApi(Configuration);
var result = api.CreateNotification(model);
return !String.IsNullOrWhiteSpace(result.Id);

Steps to reproduce?

1. Create .NET Framework 4.8.1 API
2. Create .NET Standard 2.0 Class Library
3. Install packages: OneSignalApi 1.0.1, RestSharp 108.0.1, Newtonsoft.Json 13.0.1, JsonSubTypes 1.9.0, System.ComponentModel.Annotations 5.0.0 in both projects
4. Call the class library from the api
5. Get error

What did you expect to happen?

I expected the API to send a push notification message.

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[rer145]

Related to #7. I downgraded RestSharp in both projects to 106.13.0 to match the OneSignalApi package and it works.

[rmariotti-choicelunch]

Are there plans to update this library to use the latest RestSharp (108+)?
RestSharp v107 was a large update and I have other code that also uses RestSharp v107+ features.

Much appreciated any roadmap or plans to use the "modern" RestSharp! Thanks,
Ryan

[webfletch]

Yes I would also like to know if you will be supporting the latest version of RestSharp, the latest version of Xero nuget package needs RestSharp 108.0.1 or greater but I cannot install it because OneSignal needs RestSharp below version 107.

[Jossec101]

Bump, still a big issue nowadays.

[Aleksander98]

I asked the OneSignal team via chat about this issue. It seems that we will not be getting a fix anytime soon.

[sherwinski]

Hey everyone, and sorry for the silence here. We've recently picked back up on maintaining the server SDKs (including this library) and should be investigating a fix soon. I can't give a specific timeline at the moment as I am still focusing on some broader fixes across the SDK, but will make time to look into this one specifically after.

In the meantime, I appreciate everyone's patience as we work through this and other long-standing issues.

[sherwinski]

Posting this comment here for awareness.

We are now beginning of the process of upgrading RestSharp to a newer version. I'll keep both issues updated on any progress.

[Aleksander98]

@sherwinski I saw that you've released a new beta version - great to see the package is still being maintained! However, I noticed the dependencies still haven't been updated. Do you have an estimate for when that might happen?

[sherwinski]

To give a quick update here: I've opened PRs in the upstream project (used to generate this library) that will upgrade RestSharp from v106 to v108. Originally, my aim was to upgrade to a more recent version but this was the jump that caused the least amount of headaches as of right now. Some of our team members are out on holiday at the moment so I imagine it will take a few more weeks from now until the changes are reviewed and released.

In the meantime we'd like to hear from folks on this thread: is this version bump enough to meet your needs for right now? If not, please tell us what version(s) you are targeting in your apps so we can provide the best value.

Thanks

[Aleksander98]

@sherwinski We currently have v112 as a dependency - not because we use it directly, but because it’s referenced by other packages we rely on.

Important: Whatever version you decide to use, please ensure your package is locked to a specific major version. For example, if you use v108, allow only minor and patch updates within v108 (e.g., v108.x.x), but do not permit automatic upgrades to v109 or higher.