Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken icon in bell #697

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix broken icon in bell #697

merged 1 commit into from
Sep 18, 2020

Conversation

gdeglin
Copy link
Member

@gdeglin gdeglin commented Sep 9, 2020

Description

1 Line Summary

Fixes a broken icon in the bell when no custom icon is used.

Details

The getPlatformNotificationIcon will always return an icon path or otherwise will return 'default-icon'. This change fixes a bug where we were incorrectly trying to render the URL "/default-icon" when no icon was specified.

Systems Affected

  • WebSDK

Validation

Requires validation.

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets


This change is Reviewable

The `getPlatformNotificationIcon` will always return an icon path or otherwise will return 'default-icon'. This change fixes a bug where we were incorrectly trying to render the URL "/default-icon" when no icon was specified.
@jmadler jmadler merged commit 19d6b12 into master Sep 18, 2020
@jmadler jmadler deleted the fix-default-icon-bell branch September 18, 2020 16:14
@jmadler jmadler mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants