Skip to content

Fixes Docker volume mounting and webpack-cli #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: fg/docker-fix
Choose a base branch
from

Conversation

fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Jun 26, 2025

Description

Fixes Docker volume mounting and updates webpack-cli version

Details

  • Updates the docker-compose file to anonymously mount node_modules so local node module installs are not affected
  • Updates the webpack-cli dependency in the preview package.json file since webpack expect cli to be v4 or higher
  • Updates default port to 4000 so we avoid conflicts for testing locally vs build

Systems Affected

  • WebSDK

Validation

Tests

Info

N/A

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

N/A

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@fadi-george fadi-george requested a review from sherwinski June 26, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant