Skip to content
This repository was archived by the owner on Oct 31, 2022. It is now read-only.
This repository was archived by the owner on Oct 31, 2022. It is now read-only.

OneSignal plugin increases gradle build time by a considerable amount #173

Open
@ubarua123

Description

@ubarua123

Please Add The Following

Project Setup

build.gradle

// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext.kotlin_version = '1.5.0'
    apply from: 'versions.gradle'
    ext {
        ....
    }

    repositories {
        google()
        jcenter()
        maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' }
        maven { url "https://plugins.gradle.org/m2/" }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:4.1.3'
        classpath deps.kotlin.plugin
        classpath deps.apollo.plugin
        classpath deps.google_android.googleServices_plugin
        classpath deps.firebase.crashlytics_plugin
        classpath(deps.firebase.performance_metrics_plugin) {
            exclude group: 'com.google.guava', module: 'guava-jdk5'
        }
        classpath deps.custom.aboutLibraries_plugin
        classpath 'com.project.starter:easylauncher:3.9.0'
        classpath deps.push.onesignal_plugin
    }
}

allprojects {
    repositories {
        google()
        jcenter()
        mavenCentral()
        mavenLocal()
        maven { url "https://jitpack.io" }
        maven { url "https://dl.bintray.com/unsplash/unsplash-photopicker-android" }
        maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }

        flatDir {
            dirs 'libs'
        }
    }
    afterEvaluate {
        tasks.withType(JavaCompile.class) {
            options.compilerArgs << "-Xmaxerrs" << "1000"
        }
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

// Define versions in a single place


//When there is an error in code generation you will may see
//lots of errors due too missing generated code in your logs, we increase
//how many errors are shown here so that the real error is visible when it is near the end
allprojects {

}

app/build.gradle

apply plugin: 'com.android.application'
apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt'
apply plugin: 'kotlin-parcelize'
apply plugin: 'com.apollographql.apollo'
// Apply the Crashlytics Gradle plugin
apply plugin: 'com.google.firebase.crashlytics'
apply plugin: 'com.mikepenz.aboutlibraries.plugin'
apply plugin: 'com.starter.easylauncher'

android {
    compileSdkVersion Integer.parseInt(build_versions.compile_sdk)
    buildToolsVersion build_versions.build_tools

    defaultConfig {
        applicationId rootProject.ext.APPLICATION_ID
        minSdkVersion build_versions.min_sdk
        targetSdkVersion build_versions.target_sdk
.
.
.
.
}

Full Error

No Error. However, on each build, the full build is executed even for small layout updates. Which wasn't the case till I added the plugin. I can't give any concrete timings and stats, I'll have to run tests for that. This was an observation.
Getting stuck on Download maven-metadata.xml

Dependency Tree

Run ./gradlew app:dependencies

OUTPUT HERE

OneSignal plugin version

0.13.4

OneSignal SDK version

4.4.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions