Remove Amazon IAP tracking #2333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Due low Amazon IAP and high maintenance cost of the code breaking on every Amazon IAP release remove tracking.
Details
Motivation
This code has caused crashes in the past due to not handling new versions of Amazon's IAP library.
Amazon doesn't have an official API for SDKs to track IAP, as a result
we have been using reflection to hook into internal API's. This is
extremely fragile, it breaks on every patch version of Amazon's IAP
library.
Due to the fact the mobile market as a whole is moving from away IAP through app stores and Amazon's pullback on bring the Amazon store to other platforms (like Windows) the importance has shrunk so low the maintenance is no long worth it.
Scope
Only effects Amazon In app purchase tracking to OneSignal on FireOs devices.
Testing
Unit testing
No tests to remove, there was not existing code coverage.
Manual testing
Tested on an Android 9 emulator, ensured no errors due to removed code.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is