Skip to content

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jun 30, 2025

Description

One Line Summary

Due low Amazon IAP and high maintenance cost of the code breaking on every Amazon IAP release remove tracking.

Details

Motivation

This code has caused crashes in the past due to not handling new versions of Amazon's IAP library.

Amazon doesn't have an official API for SDKs to track IAP, as a result
we have been using reflection to hook into internal API's. This is
extremely fragile, it breaks on every patch version of Amazon's IAP
library.

Due to the fact the mobile market as a whole is moving from away IAP through app stores and Amazon's pullback on bring the Amazon store to other platforms (like Windows) the importance has shrunk so low the maintenance is no long worth it.

Scope

Only effects Amazon In app purchase tracking to OneSignal on FireOs devices.

Testing

Unit testing

No tests to remove, there was not existing code coverage.

Manual testing

Tested on an Android 9 emulator, ensured no errors due to removed code.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Amazon doesn't have an official API for SDKs to track IAP, as a result
we have been using reflection to hook into internal API's. This is
extremely fragile, it breaks on every patch version of Amazon's IAP
library.

Due to the fact the market is moving away IAP through app stores and
Amazon's pullback on bring the Amazon store to other platforms
(like Windows) the importance has shrunk so low the maintenance isn't
worth it anymore.
@nan-li
Copy link
Contributor

nan-li commented Jun 30, 2025

I agree here with the removal

Base automatically changed from main-gradle8-and-central-portal to main June 30, 2025 20:25
@jkasten2 jkasten2 merged commit 2384534 into main Jun 30, 2025
2 checks passed
@jkasten2 jkasten2 deleted the rm-amazon-iap-tracking branch June 30, 2025 20:26
@jkasten2 jkasten2 mentioned this pull request Jun 30, 2025
nan-li pushed a commit that referenced this pull request Jul 8, 2025
@nan-li nan-li mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants