V4 to v5 upgrade will migrate app ID for wrapper SDKs #2244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
(Resolves an issue that only affects wrappers) When migrating from v4 to v5, check for a cached app ID from v4 if none are available on v5.
Details
Motivation
initWithContext
returns early.onCreate
is automatically called, without needing to open the app. In native SDK clients, their OneSignal initialization code will run here and populate the app ID, setup the user, etc. However, in wrappers, clients don't modify the native code so theonCreate
does not set app ID.Scope
Testing
Unit testing
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is