[User model] Push Subscription Changed Event #1768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Updating the User subscription observers
Details
Email and SMS subscription observers have been removed and the push subscription observer has been updated.
The previous ISubscription interface now only has id, and IPushSubscription has add/remove observer
Motivation
event rework
Scope
subscription observers
Testing
Unit testing
none
Manual testing
tested the push subscription opted In, token, and id changes fire properly
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is