Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User model] Push Subscription Changed Event #1768

Merged
merged 3 commits into from
May 1, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Apr 28, 2023

Description

One Line Summary

Updating the User subscription observers

Details

Email and SMS subscription observers have been removed and the push subscription observer has been updated.

The previous ISubscription interface now only has id, and IPushSubscription has add/remove observer

Motivation

event rework

Scope

subscription observers

Testing

Unit testing

none

Manual testing

tested the push subscription opted In, token, and id changes fire properly

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

brismithers and others added 2 commits April 28, 2023 15:04
Only the push subscription can now be observed. Moving oberservable behavior out of ISubscription and into IPushSubscription

Removing old subscription observer from MainActivityViewModel
We only want to fire the changeHandlersNotifier for push subs but the onSubscriptionChanged for all subscriptions.
@emawby emawby changed the base branch from main to user-model/main April 28, 2023 22:46
@emawby emawby merged commit 23433b6 into user-model/main May 1, 2023
@emawby emawby deleted the user-model/user-events branch May 1, 2023 18:39
@emawby emawby mentioned this pull request May 1, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User model] Push Subscription Changed Event
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
[User model] Push Subscription Changed Event
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
[User model] Push Subscription Changed Event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants