Skip to content

[User Model] Pre-Beta Fixes #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Feb 2, 2023

  • Add new logo to example app
  • Set SDK-Wrapper header based on new OneSignalWrapper interface, to be set by wrapper SDKs.
  • Remove clickId and pageId from IInAppMessageAction, these should not be public.
  • Rework IAM dismiss flow so close button will drive click handler.
  • Drive re-evaluation of IAMs when IInAppMessageManager.paused is set to true.
  • Change INotificationsManager removeNotification functions to no longer be suspending functions.
  • Fix issue where notification received callbacks taking longer than 30 seconds would still be waited for.

This change is Reviewable

* Add new logo to example app
* Set `SDK-Wrapper` header based on new OneSignalWrapper interface, to be set by wrapper SDKs.
* Remove `clickId` and `pageId` from IInAppMessageAction, these should not be public.
* Rework IAM dismiss flow so close button will drive click handler.
* Drive re-evaluation of IAMs when IInAppMessageManager.paused is set to true.
* Change INotificationsManager removeNotification functions to no longer be suspending functions.
* Fix issue where notification received callbacks taking longer than 30 seconds would still be waited for.
@brismithers brismithers merged commit 952de92 into user-model/main Feb 2, 2023
@brismithers brismithers deleted the user-model/pre-beta-fixes branch February 2, 2023 18:43
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant