[Add] notification permission prompting callback and In-App Message support #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new public method overload for promptForPushNotifications to accept a new optional PromptForPushNotificationPermissionResponseHandler type. This fires when the user accepts or declines the notification permission, includes handling of the fallbackToSettings logic as well.
We support multiple callbacks for location so adding this to notifications to match. This is to ensure events are not missed for any reason.
Add support for notification permission prompting to In-App Messaging.
jkasten2
force-pushed
the
add/notification_permission_prompting_callback_and_iam
branch
from
4ea9662 to
550caa3
Compare
jkasten2
changed the title
emawby
approved these changes
Jun 28, 2022
jkasten2
deleted the
add/notification_permission_prompting_callback_and_iam
branch
Merged
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds optional notification permission prompting callback to
promptForPushNotificationsand adds support to prompt from In-App Messages as well.Details
Motivation
Since Android 13 now requires permission just like iOS we are want the features set to match 1-to-1 with our OneSignal-iOS-SDK.
Scope
Only affects notification permission prompting and prompting from In-App Messages.
Testing
Manual testing
Tested on Android 13 Beta 3 (API 33) Emulator to ensure the callback fires when it should.
New IAM notification prompt not tested, however it is essentially behind a feature flag. If something is wrong we can omit this specific SDK version and make another PR to address any bug fixes.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is