Skip to content

Conversation

@theEvilReaper
Copy link
Contributor

Proposed changes

The pull request fixes an issue that the all endpoint doesn't return the objects in a page.
Closes #35

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Sep 23, 2025
@theEvilReaper theEvilReaper added the enhancement New feature or request label Sep 23, 2025
@theEvilReaper theEvilReaper changed the base branch from next to beta September 23, 2025 09:06
Copy link
Contributor

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMeinerLP TheMeinerLP merged commit e030a6e into beta Sep 26, 2025
4 checks passed
@TheMeinerLP TheMeinerLP deleted the fix/sound_controller_get_all_return_type branch September 26, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Invalid return type in SoundEvents 'all' endpoint

3 participants