Pull upstream (#73)

* Fix entity position desync when spawned in an 8 block radius from world center (0,0,0) (Minestom#2299)

* fix: entity spawn pos desync

* Fix tests

* Update API for swept entity <-> entity collisions (Minestom#2343)

* Update API for swept entity <-> entity collisions

* Move EntityCollisionResult to its own class (Minestom#2345)

* Move EntityCollisionResult to its own class

* Return directional information from entity collision (Minestom#2346)

* fix entity collisions (Minestom#2348)

* Ability to get collision shape position from PhysicsResult (Minestom#2355)

* ability to get collision shape position from PhysicsResult

* Coordinate limit to prevent potential overflow

* fix some jcstress files

* clear remaining hephaistos usage

* Make BoundingBox/ShapeImpl records (Minestom#2371)

* Use a single int for all block states (Minestom#2373)

* Light cleanup (Minestom#2372)

* record namespace (Minestom#2374)

* Add EquipmentSlot.BODY (Minestom#2325)

* Add EquipmentSlot.BODY

* EntityEquipmentPacket should now have 7 entries

* Simplify isHand check

* Fix tests

---------

Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com>

* unused cache

* Implement Graph Cache in CommandManager (Minestom#2360)

* update dependencies

* Remove caffeine dependency from EventNode (Minestom#2375)

* Remove mojang utils cache

* fix team visibility (Minestom#2186)

* Fix chunks not being refreshed when view distance updates (Minestom#2197)

* Fix chunks not being refreshed when view distance updates

* give more control of collisions to the entities colliding (Minestom#2350)

* give more control of collisions to the entities colliding

* Playsound exclude (Minestom#2381)

* Add Instance::playSoundExcept

* Uh...

* fix: saturation not working in food item component (Minestom#2382)

* fix missing inversion in DataComponentMap#diff handling for removed entries (Minestom#2359)

* More Vec operator, more min/max methods

* Remove no longer exists methods

* Disable failed test

* Improve AtomicReference handling

* Fix test execution when loading chunk outside of the main thread

* Improve AtomicReference handling in some tests

---------

Co-authored-by: Am Gone <67794767+Am-Gone@users.noreply.github.com>
Co-authored-by: iam <iam4722202468@users.noreply.github.com>
Co-authored-by: Lorenz Wrobel <43410952+DasBabyPixel@users.noreply.github.com>
Co-authored-by: themode <themode@outlook.fr>
Co-authored-by: TogAr2 <59421074+TogAr2@users.noreply.github.com>
Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com>
Co-authored-by: Kerman <46640204+KermanIsPretty@users.noreply.github.com>
Co-authored-by: bea4dev <34712108+bea4dev@users.noreply.github.com>
Co-authored-by: GreatWyrm <alecmusante@gmail.com>
Co-authored-by: Samuel <pifnpafnpouf@gmail.com>
Co-authored-by: SLH <114884726+SLH335@users.noreply.github.com>
Co-authored-by: Floweynt <50057682+Floweynt@users.noreply.github.com>
Co-authored-by: theEvilReaper <steffenwx@gmail.com>

Author: 14 people

src/test/java/net/minestom/server/ServerProcessTest.java

@@ -21,6 +21,7 @@ void init() {
         assertDoesNotThrow(() -> process.get().start(new InetSocketAddress("localhost", 25565)));
         assertThrows(Exception.class, () -> process.get().start(new InetSocketAddress("localhost", 25566)));
         assertDoesNotThrow(() -> process.get().stop());
+        process.set(null);
     }
 
     @Test

src/test/java/net/minestom/server/collision/EntityProjectileCollisionIntegrationTest.java

@@ -71,6 +71,8 @@ void blockShootAndBlockRemoval(Env env) {
         assertNotNull(event);
         assertNotNull(event2);
         assertEquals(blockPosition.withY(y -> y - 1), new Vec(event.getCollisionPosition().blockX(), event.getCollisionPosition().blockY(), event.getCollisionPosition().blockZ()));
+        eventRef.set(null);
+        eventRef2.set(null);
     }
 
     @Test
@@ -151,6 +153,6 @@ void entitySelfShoot(Env env) {
         assertNotNull(event);
         assertSame(shooter, event.getTarget());
         assertTrue(shooter.getBoundingBox().intersectEntity(shooter.getPosition(), projectile));
+        eventRef.set(null);
     }
-
 }

src/test/java/net/minestom/server/command/CommandParseTest.java

@@ -89,6 +89,7 @@ void singleCommandOptionalArgs() {
         assertValid(foo, "foo T", b);
         expectedFirstArg.set("A");
         assertValid(foo, "foo", b);
+        expectedFirstArg.set(null);
     }
 
     @Test

src/test/java/net/minestom/server/command/CommandSyntaxSingleTest.java

@@ -174,6 +174,9 @@ private static void assertSyntax(List<Argument<?>> args, String input, ExpectedE
         if (expectedValues != null) {
             assertEquals(expectedValues, values.get());
         }
+
+        result.set(null);
+        values.set(null);
     }
 
     private static void assertSyntax(List<Argument<?>> args, String input, ExpectedExecution expectedExecution) {

src/test/java/net/minestom/server/entity/player/PlayerMovementIntegrationTest.java

@@ -47,6 +47,8 @@ void teleportConfirm(Env env) {
         p1.addPacketToQueue(new ClientPlayerPositionPacket(new Pos(0.2, 40, 0), true));
         p1.interpretPacketQueue();
         assertEquals(new Pos(0.2, 40, 0), p1.getPosition());
+        p1.remove();
+        env.destroyInstance(instance);
     }
 
     // FIXME
@@ -119,6 +121,8 @@ void chunkUpdateDebounceTest(Env env) {
         player.addPacketToQueue(new ClientPlayerPositionPacket(new Vec(16.5, 40, -16.5), true));
         player.interpretPacketQueue();
         chunkDataPacketCollector.assertCount(viewDiameter * 2 - 1);
+        player.remove();
+        env.destroyInstance(flatInstance);
     }
 
     @Test
@@ -140,6 +144,39 @@ void testClientViewDistanceSettings(Env env) {
         player.addPacketToQueue(new ClientPlayerPositionPacket(new Vec(160.5, 40, 160.5), true));
         player.interpretPacketQueue();
         chunkDataPacketCollector.assertCount(MathUtils.square(viewDistance * 2 + 1));
+        player.remove();
+        env.destroyInstance(flatInstance);
+    }
+
+    @Test
+    public void testSettingsViewDistanceExpansionAndShrink(Env env) {
+        int startingViewDistance = 8;
+        byte endViewDistance = 12;
+        byte finalViewDistance = 10;
+        var instance = env.createFlatInstance();
+        var connection = env.createConnection();
+        Pos startingPlayerPos = new Pos(0, 42, 0);
+        var player = connection.connect(instance, startingPlayerPos).join();
+
+        int chunkDifference = ChunkUtils.getChunkCount(endViewDistance) - ChunkUtils.getChunkCount(startingViewDistance);
+        // Preload chunks, otherwise our first tracker.assertCount call will fail randomly due to chunks being loaded off the main thread
+        Set<CompletableFuture<Chunk>> chunks = new HashSet<>();
+        ChunkUtils.forChunksInRange(0, 0, endViewDistance, (v1, v2) -> chunks.add(instance.loadChunk(v1, v2)));
+        CompletableFuture.allOf(chunks.toArray(CompletableFuture[]::new)).join();
+
+        var tracker = connection.trackIncoming(ChunkDataPacket.class);
+        player.addPacketToQueue(new ClientSettingsPacket("en_US", endViewDistance, ChatMessageType.FULL, false, (byte) 0, Player.MainHand.RIGHT, false, true));
+        player.interpretPacketQueue();
+        tracker.assertCount(chunkDifference);
+
+        var tracker1 = connection.trackIncoming(UnloadChunkPacket.class);
+        player.addPacketToQueue(new ClientSettingsPacket("en_US", finalViewDistance, ChatMessageType.FULL, false, (byte) 0, Player.MainHand.RIGHT, false, true));
+        player.interpretPacketQueue();
+
+        int chunkDifference1 = ChunkUtils.getChunkCount(endViewDistance) - ChunkUtils.getChunkCount(finalViewDistance);
+        tracker1.assertCount(chunkDifference1);
+        player.remove();
+        env.destroyInstance(instance);
     }
 
     @Test

src/test/java/net/minestom/server/instance/GeneratorIntegrationTest.java

@@ -47,6 +47,7 @@ void exceptionCatch(Env env) {
         instance.loadChunk(0, 0).join();
 
         assertSame(exception, ref.get());
+        ref.set(null);
     }
 
     @Test

src/test/java/net/minestom/server/instance/InstanceBlockIntegrationTest.java

@@ -83,7 +83,6 @@ void blockNbt(Env env) {
 
     @Test
     public void handlerPresentInPlacementRuleUpdate(Env env) {
-
         AtomicReference<Block> currentBlock = new AtomicReference<>();
         env.process().block().registerHandler(SuspiciousGravelBlockHandler.INSTANCE.getNamespaceId(), () -> SuspiciousGravelBlockHandler.INSTANCE);
         env.process().block().registerBlockPlacementRule(new BlockPlacementRule(Block.SUSPICIOUS_GRAVEL) {
@@ -105,5 +104,6 @@ public void handlerPresentInPlacementRuleUpdate(Env env) {
         instance.setBlock(1, 50, 0, theBlock);
 
         assertEquals(theBlock, currentBlock.get());
+        currentBlock.set(null);
     }
 }

src/test/java/net/minestom/server/instance/anvil/AnvilLoaderIntegrationTest.java

@@ -74,6 +74,7 @@ public void parallelSaveNonexistentFiles(Env env) throws Exception {
         });
         instance.saveChunksToStorage().join();
         assertNull(exception.get());
+        exception.set(null);
     }
 
     @Test

src/test/java/net/minestom/server/instance/generator/GeneratorForkConsumerIntegrationTest.java

@@ -32,6 +32,7 @@ void empty(Env env) {
         });
         instance.loadChunk(0, 0).join();
         assertNull(failed.get(), "Failed: " + failed.get());
+        failed.set(null);
     }
 
     @Test