forked from Minestom/Minestom
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Pull upstream #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pull upstream #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld center (0,0,0) (Minestom#2299) * fix: entity spawn pos desync * Fix tests
* Update API for swept entity <-> entity collisions
* Move EntityCollisionResult to its own class
…2355) * ability to get collision shape position from PhysicsResult
* Add EquipmentSlot.BODY * EntityEquipmentPacket should now have 7 entries * Simplify isHand check * Fix tests --------- Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com>
* Add Instance::playSoundExcept * Uh...
|
theEvilReaper
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TheMeinerLP
added a commit
that referenced
this pull request
Oct 31, 2024
* Fix entity position desync when spawned in an 8 block radius from world center (0,0,0) (Minestom#2299) * fix: entity spawn pos desync * Fix tests * Update API for swept entity <-> entity collisions (Minestom#2343) * Update API for swept entity <-> entity collisions * Move EntityCollisionResult to its own class (Minestom#2345) * Move EntityCollisionResult to its own class * Return directional information from entity collision (Minestom#2346) * fix entity collisions (Minestom#2348) * Ability to get collision shape position from PhysicsResult (Minestom#2355) * ability to get collision shape position from PhysicsResult * Coordinate limit to prevent potential overflow * fix some jcstress files * clear remaining hephaistos usage * Make BoundingBox/ShapeImpl records (Minestom#2371) * Use a single int for all block states (Minestom#2373) * Light cleanup (Minestom#2372) * record namespace (Minestom#2374) * Add EquipmentSlot.BODY (Minestom#2325) * Add EquipmentSlot.BODY * EntityEquipmentPacket should now have 7 entries * Simplify isHand check * Fix tests --------- Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> * unused cache * Implement Graph Cache in CommandManager (Minestom#2360) * update dependencies * Remove caffeine dependency from EventNode (Minestom#2375) * Remove mojang utils cache * fix team visibility (Minestom#2186) * Fix chunks not being refreshed when view distance updates (Minestom#2197) * Fix chunks not being refreshed when view distance updates * give more control of collisions to the entities colliding (Minestom#2350) * give more control of collisions to the entities colliding * Playsound exclude (Minestom#2381) * Add Instance::playSoundExcept * Uh... * fix: saturation not working in food item component (Minestom#2382) * fix missing inversion in DataComponentMap#diff handling for removed entries (Minestom#2359) * More Vec operator, more min/max methods * Remove no longer exists methods * Disable failed test * Improve AtomicReference handling * Fix test execution when loading chunk outside of the main thread * Improve AtomicReference handling in some tests --------- Co-authored-by: Am Gone <67794767+Am-Gone@users.noreply.github.com> Co-authored-by: iam <iam4722202468@users.noreply.github.com> Co-authored-by: Lorenz Wrobel <43410952+DasBabyPixel@users.noreply.github.com> Co-authored-by: themode <themode@outlook.fr> Co-authored-by: TogAr2 <59421074+TogAr2@users.noreply.github.com> Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> Co-authored-by: Kerman <46640204+KermanIsPretty@users.noreply.github.com> Co-authored-by: bea4dev <34712108+bea4dev@users.noreply.github.com> Co-authored-by: GreatWyrm <alecmusante@gmail.com> Co-authored-by: Samuel <pifnpafnpouf@gmail.com> Co-authored-by: SLH <114884726+SLH335@users.noreply.github.com> Co-authored-by: Floweynt <50057682+Floweynt@users.noreply.github.com> Co-authored-by: theEvilReaper <steffenwx@gmail.com>
TheMeinerLP
added a commit
that referenced
this pull request
Jan 6, 2025
* Fix entity position desync when spawned in an 8 block radius from world center (0,0,0) (Minestom#2299) * fix: entity spawn pos desync * Fix tests * Update API for swept entity <-> entity collisions (Minestom#2343) * Update API for swept entity <-> entity collisions * Move EntityCollisionResult to its own class (Minestom#2345) * Move EntityCollisionResult to its own class * Return directional information from entity collision (Minestom#2346) * fix entity collisions (Minestom#2348) * Ability to get collision shape position from PhysicsResult (Minestom#2355) * ability to get collision shape position from PhysicsResult * Coordinate limit to prevent potential overflow * fix some jcstress files * clear remaining hephaistos usage * Make BoundingBox/ShapeImpl records (Minestom#2371) * Use a single int for all block states (Minestom#2373) * Light cleanup (Minestom#2372) * record namespace (Minestom#2374) * Add EquipmentSlot.BODY (Minestom#2325) * Add EquipmentSlot.BODY * EntityEquipmentPacket should now have 7 entries * Simplify isHand check * Fix tests --------- Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> * unused cache * Implement Graph Cache in CommandManager (Minestom#2360) * update dependencies * Remove caffeine dependency from EventNode (Minestom#2375) * Remove mojang utils cache * fix team visibility (Minestom#2186) * Fix chunks not being refreshed when view distance updates (Minestom#2197) * Fix chunks not being refreshed when view distance updates * give more control of collisions to the entities colliding (Minestom#2350) * give more control of collisions to the entities colliding * Playsound exclude (Minestom#2381) * Add Instance::playSoundExcept * Uh... * fix: saturation not working in food item component (Minestom#2382) * fix missing inversion in DataComponentMap#diff handling for removed entries (Minestom#2359) * More Vec operator, more min/max methods * Remove no longer exists methods * Disable failed test * Improve AtomicReference handling * Fix test execution when loading chunk outside of the main thread * Improve AtomicReference handling in some tests --------- Co-authored-by: Am Gone <67794767+Am-Gone@users.noreply.github.com> Co-authored-by: iam <iam4722202468@users.noreply.github.com> Co-authored-by: Lorenz Wrobel <43410952+DasBabyPixel@users.noreply.github.com> Co-authored-by: themode <themode@outlook.fr> Co-authored-by: TogAr2 <59421074+TogAr2@users.noreply.github.com> Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> Co-authored-by: Kerman <46640204+KermanIsPretty@users.noreply.github.com> Co-authored-by: bea4dev <34712108+bea4dev@users.noreply.github.com> Co-authored-by: GreatWyrm <alecmusante@gmail.com> Co-authored-by: Samuel <pifnpafnpouf@gmail.com> Co-authored-by: SLH <114884726+SLH335@users.noreply.github.com> Co-authored-by: Floweynt <50057682+Floweynt@users.noreply.github.com> Co-authored-by: theEvilReaper <steffenwx@gmail.com>
TheMeinerLP
added a commit
that referenced
this pull request
Jan 6, 2025
* Fix entity position desync when spawned in an 8 block radius from world center (0,0,0) (Minestom#2299) * fix: entity spawn pos desync * Fix tests * Update API for swept entity <-> entity collisions (Minestom#2343) * Update API for swept entity <-> entity collisions * Move EntityCollisionResult to its own class (Minestom#2345) * Move EntityCollisionResult to its own class * Return directional information from entity collision (Minestom#2346) * fix entity collisions (Minestom#2348) * Ability to get collision shape position from PhysicsResult (Minestom#2355) * ability to get collision shape position from PhysicsResult * Coordinate limit to prevent potential overflow * fix some jcstress files * clear remaining hephaistos usage * Make BoundingBox/ShapeImpl records (Minestom#2371) * Use a single int for all block states (Minestom#2373) * Light cleanup (Minestom#2372) * record namespace (Minestom#2374) * Add EquipmentSlot.BODY (Minestom#2325) * Add EquipmentSlot.BODY * EntityEquipmentPacket should now have 7 entries * Simplify isHand check * Fix tests --------- Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> * unused cache * Implement Graph Cache in CommandManager (Minestom#2360) * update dependencies * Remove caffeine dependency from EventNode (Minestom#2375) * Remove mojang utils cache * fix team visibility (Minestom#2186) * Fix chunks not being refreshed when view distance updates (Minestom#2197) * Fix chunks not being refreshed when view distance updates * give more control of collisions to the entities colliding (Minestom#2350) * give more control of collisions to the entities colliding * Playsound exclude (Minestom#2381) * Add Instance::playSoundExcept * Uh... * fix: saturation not working in food item component (Minestom#2382) * fix missing inversion in DataComponentMap#diff handling for removed entries (Minestom#2359) * More Vec operator, more min/max methods * Remove no longer exists methods * Disable failed test * Improve AtomicReference handling * Fix test execution when loading chunk outside of the main thread * Improve AtomicReference handling in some tests --------- Co-authored-by: Am Gone <67794767+Am-Gone@users.noreply.github.com> Co-authored-by: iam <iam4722202468@users.noreply.github.com> Co-authored-by: Lorenz Wrobel <43410952+DasBabyPixel@users.noreply.github.com> Co-authored-by: themode <themode@outlook.fr> Co-authored-by: TogAr2 <59421074+TogAr2@users.noreply.github.com> Co-authored-by: Matt Worzala <35708499+mworzala@users.noreply.github.com> Co-authored-by: Kerman <46640204+KermanIsPretty@users.noreply.github.com> Co-authored-by: bea4dev <34712108+bea4dev@users.noreply.github.com> Co-authored-by: GreatWyrm <alecmusante@gmail.com> Co-authored-by: Samuel <pifnpafnpouf@gmail.com> Co-authored-by: SLH <114884726+SLH335@users.noreply.github.com> Co-authored-by: Floweynt <50057682+Floweynt@users.noreply.github.com> Co-authored-by: theEvilReaper <steffenwx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...