Skip to content

feat: added update checker #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

tarna
Copy link
Contributor

@tarna tarna commented Nov 28, 2024

Proposed changes

Adds an update checker that fetches the latest version from hangar and if the versions don't match, it sends a message to players who have the permission attollo.update when they join. Resolves issue #61.

I wasn't sure what type of message you wanted so I just put some random one. You guys can change it to what you guys prefer.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@tarna tarna requested a review from a team as a code owner November 28, 2024 22:22
@tarna tarna requested review from Sayn3x and removed request for a team November 28, 2024 22:22
@tarna
Copy link
Contributor Author

tarna commented Nov 29, 2024

added all the new requested changes

@tarna
Copy link
Contributor Author

tarna commented Nov 29, 2024

have turned the update messages to constants like requested

@TheMeinerLP
Copy link
Collaborator

Have you tested locally ?

@tarna
Copy link
Contributor Author

tarna commented Dec 4, 2024

Have you tested locally ?

Yes, I have. When testing locally, I temporarily change the plugin version to something lower.

Copy link
Collaborator

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMeinerLP TheMeinerLP added this pull request to the merge queue Dec 12, 2024
Merged via the queue into OneLiteFeatherNET:develop with commit 98f6d15 Dec 12, 2024
1 check passed
@tarna tarna deleted the update-checker branch December 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants