-
Notifications
You must be signed in to change notification settings - Fork 4
feat: added update checker #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeinerLP
requested changes
Nov 28, 2024
src/main/kotlin/dev/themeinerlp/attollo/listener/UpdateCheckerListener.kt
Outdated
Show resolved
Hide resolved
TheMeinerLP
requested changes
Nov 29, 2024
src/main/kotlin/dev/themeinerlp/attollo/service/UpdateService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dev/themeinerlp/attollo/service/UpdateService.kt
Outdated
Show resolved
Hide resolved
added all the new requested changes |
TheMeinerLP
requested changes
Nov 29, 2024
src/main/kotlin/dev/themeinerlp/attollo/service/UpdateService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dev/themeinerlp/attollo/service/UpdateService.kt
Outdated
Show resolved
Hide resolved
have turned the update messages to constants like requested |
TheMeinerLP
requested changes
Dec 4, 2024
src/main/kotlin/dev/themeinerlp/attollo/listener/UpdateCheckerListener.kt
Show resolved
Hide resolved
Have you tested locally ? |
Yes, I have. When testing locally, I temporarily change the plugin version to something lower. |
TheMeinerLP
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds an update checker that fetches the latest version from hangar and if the versions don't match, it sends a message to players who have the permission
attollo.update
when they join. Resolves issue #61.I wasn't sure what type of message you wanted so I just put some random one. You guys can change it to what you guys prefer.
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
N/A