Skip to content

feat: adding log info for block config #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

JosTheDude
Copy link
Contributor

@JosTheDude JosTheDude commented Nov 26, 2024

Proposed changes

Adds basic logging on load to what the block configuration is set too, as well as a warning if the proposed value is incorrect. Better debugging for users.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@JosTheDude JosTheDude requested a review from a team as a code owner November 26, 2024 22:34
@JosTheDude JosTheDude requested review from joelramilison and removed request for a team November 26, 2024 22:34
Copy link
Collaborator

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMeinerLP
Copy link
Collaborator

Thanks for your contribution

@TheMeinerLP TheMeinerLP merged commit d2d58e3 into OneLiteFeatherNET:develop Nov 28, 2024
5 of 6 checks passed
@JosTheDude JosTheDude deleted the patch-1 branch November 29, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants