-
Notifications
You must be signed in to change notification settings - Fork 21
fix: mock device generate #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughReplaced a forEach callback with a sequential for-of loop in a test component. Each mockDevice call now uses await inside try/catch, processing btcGetAddress, evmGetAddress, and dnxGetAddress in order. Data aggregation and logging remain unchanged. No exported/public API changes. Changes
Sequence Diagram(s)sequenceDiagram
participant Tester
participant TestComponent as TestSpecialPassphraseWallet
participant Mock as mockDevice
Tester->>TestComponent: run test
loop for method in [btcGetAddress, evmGetAddress, dnxGetAddress]
TestComponent->>Mock: mockDevice(method, path)
activate Mock
Mock-->>TestComponent: Promise resolved/rejected
deactivate Mock
alt success
TestComponent->>TestComponent: push {address, path, method, key}
else error
TestComponent->>TestComponent: handle error in catch
end
end
TestComponent-->>Tester: results/logs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Summary by CodeRabbit
New Features
Refactor
Tests
Chores