fix: ext appStorage save as object OK-34155

[sidmorizon]

Summary by CodeRabbit

• 新特性

  • 更新了存储功能，使其支持在浏览器和扩展环境中保存对象。
  • 确保存储操作在后台执行，增强了控制流程。

• bug修复

  • removeItem 方法的实现进行了修改，以保持与其他方法的一致性。

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

总览

遍历

此次更改涉及三个文件：appStorageUtils.ts、syncStorage.ts 和 assertUtils.ts。在 appStorageUtils.ts 中，canSaveAsObject 函数的条件逻辑被扩展，增加了对扩展环境的检查。在 syncStorage.ts 中，引入了 ensureRunOnBackground 函数，并在存储操作方法中强制执行后台运行。assertUtils.ts 文件则更新了存储访问方式，从直接导入 appStorage 转向使用 appGlobals。

变更

文件	变更摘要
packages/shared/src/storage/appStorageUtils.ts	修改 canSaveAsObject 函数，增加对扩展环境的检查
packages/shared/src/storage/syncStorage.ts	引入 ensureRunOnBackground，更新存储操作方法以确保后台执行
packages/shared/src/utils/assertUtils.ts	更新存储访问方式，改为使用 appGlobals

序列图

sequenceDiagram
    participant Storage as 存储模块
    participant Background as 后台进程
    
    Storage->>Background: ensureRunOnBackground()
    Background-->>Storage: 验证后台执行
    Storage->>Storage: 执行存储操作

Loading

这个序列图展示了在执行存储操作之前，系统如何确保在后台进程中运行。

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c59a3f0 and 000e112.

📒 Files selected for processing (1)

• packages/shared/src/utils/assertUtils.ts (2 hunks)

🔇 Additional comments (3)

packages/shared/src/utils/assertUtils.ts (3)

13-13: 引入 appGlobals 更明朗。
把存储逻辑集中到全局对象，结构更清晰。

---

16-16: 更新 EAppSyncStorageKeys 路径。
引用新路径符合拆分策略，没发现隐患。

---

119-119: 获取配置对象逻辑更统一。
可选链方式安全可靠，逻辑无偏差。