fix: verify evm txid return by custom rpc

[weatherstar]

Summary by CodeRabbit

• 新功能

  • 引入了新的事务 ID 验证方法，增强了事务广播的可靠性。
  • 在多个组件中改进了导航状态管理，优化了多事务确认流程。

• Bug 修复

  • 改进了事务广播过程中对无效事务 ID 的处理，确保只有有效的事务 ID 被接受。

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

概述

代码变更解析

步骤详解

这组变更主要涉及交易广播和验证机制的增强。具体包括在 ServiceSend、VaultBase 和 EVM Vault 中添加了新的事务 ID 验证逻辑，并在 SendConfirmFromSwap 组件中优化了导航状态管理。这些修改旨在提高交易处理的健壮性和可靠性。

变更详情

文件路径	变更摘要
packages/kit-bg/src/services/ServiceSend.ts	在 broadcastTransaction 方法中新增错误处理机制，增加事务 ID 验证
packages/kit-bg/src/vaults/base/VaultBase.ts	添加 verifyTxId 方法，目前返回 true
packages/kit-bg/src/vaults/impls/evm/Vault.ts	新增 verifyTxId 方法，实现事务 ID 哈希验证；修改 broadcastTransactionFromCustomRpc 返回结构
packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx	调整导航状态管理，优化 navigationToNext 引用的使用

序列图

sequenceDiagram
    participant Vault
    participant ServiceSend
    participant SendConfirm

    Vault->>ServiceSend: broadcastTransaction
    ServiceSend->>Vault: verifyTxId
    Vault-->>ServiceSend: 验证结果
    ServiceSend->>SendConfirm: 导航状态更新

Loading

这个序列图展示了事务广播、验证和导航状态管理的基本流程。

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f1eff6 and 35b400c.

📒 Files selected for processing (4)

• packages/kit-bg/src/services/ServiceSend.ts (1 hunks)
• packages/kit-bg/src/vaults/base/VaultBase.ts (1 hunks)
• packages/kit-bg/src/vaults/impls/evm/Vault.ts (1 hunks)
• packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx (2 hunks)

🔇 Additional comments (3)

packages/kit/src/views/Send/pages/SendConfirmFromSwap/SendConfirmFromSwap.tsx (1)

126-126: 确保本地标记准确无误。
此处给 navigationToNext.current 赋值为 true，帮助控制流程。若后续流程中异常退出，别忘记及时重置，避免重复导航。

packages/kit-bg/src/vaults/impls/evm/Vault.ts (1)

1235-1235: 返回值新增 txid。
此处返回交易哈希，能提升后续处理效率。实现简洁明了。

packages/kit-bg/src/vaults/base/VaultBase.ts (1)

1422-1428: 这里直接返回 true。
若需实际校验，请补上真实逻辑。也可在日志中标明此方法尚未实现，以免使用者误判。

[Mariozisa1]

https://github.com/OneKeyHQ/app-monorepo/pull/6408/files