Skip to content

Conversation

@JuliaHa0902
Copy link
Contributor

Description

Combine the functionality of the mini filter and the big filter for weekly summaries.

Related PRS (if any):

This backend PR is related to the #4629 end PR.
To test this backend PR you need to checkout the #4629 frontend PR.

Main changes explained:

  • Move API logic to weeklySummariesFilterAction
  • Move all the filter modals to the component folder
  • Connect the frontend of the mini-filter with the API logic in weeklySummariesFilterAction
  • Add filter API logic to UserTeamTable and TeamTable

How to test:

  1. check into current branch
  2. do npm install, npm run build and ... to run this PR locally
  3. Check the frontend to PR 4629
  4. Clear site data/cache
  5. log as admin/owner user
  6. go to report > Weekly Summaries Reports
  7. Test the mini filter function in the Select Team Code. Verify that the mini filter function works and identical with the filter in Select Filter button and Manage Filter button

Screenshots or videos of changes:

PR.test.guide.mp4

Note:

Include the information the reviewers need to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants