Nikita - core team members additional hours should be processed properly #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge it to get the latest changes
…hours-should-be-processed-properly
…hours-should-be-processed-properly
…hours-should-be-processed-properly
…hours-should-be-processed-properly fixing merge issues
Anusha-Gali
approved these changes
Dec 17, 2025
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Nikita,
I have reviewed your PR locally, the tests run as instructed and fail as expected due to existing logic gaps noted in the PR (additional hour carryover and infringement assignment). Failures are valid and not related to test setup.
one-community
changed the title
one-community
changed the title
|
I ran the tests locally and confirmed they fail as expected. Since this PR is specifically about adding test cases that highlight gaps in the current logic, the failures are valid and reproducible. The test setup looks good, and the structure is clear. Approving this PR. |
VijayAnirudh
approved these changes
Dec 19, 2025
feat: Implement material cost router and controller test: Add integration tests for material cost router fix: Remove unnecessary whitespace in most wasted router test: Update mouseover text router test description refactor: Modify PR insights router to accept user profile fix: Clean up project material routes by removing extra whitespace test: Update project router test description test: Update reason router test description feat: Create resource request router with necessary endpoints feat: Enhance student task router to include file upload functionality feat: Introduce supplier performance router for summary dashboard refactor: Clean up tag router for better readability feat: Add delete task route to task router test: Update time zone API routes test description feat: Enhance time entry router with better formatting feat: Add final day update route to user profile router test: Update user profile router test description feat: Create weekly summaries filter router with CRUD operations chore: Integrate pull request review jobs into server startup feat: Implement S3 service for file uploads fix: Clean up BiddingService connection server fix: Reorder logger import in db startup fix: Clean up middleware imports feat: Add supplier performance model to routes feat: Add browsable lesson plan router to server feat: Add lesson plan submission router to server fix: Update mock request structure for better clarity fix: Clean up SMSSender utility chore: Update initial permissions to include new actions feat: Introduce RateLimitedError for better error handling fix: Clean up global error handler imports feat: Add clearByPrefix method to node cache utility fix: Update permission spec imports for consistency fix: Clean up permissions utility for better readability fix: Clean up websocket index imports fix: Reorder imports in messaging socket for clarity
one-community
added
the
Do Not Review
one-community
added
the
Needs New Developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrote JEST Tests to test the funtionality
Related PRS (if any):
#1141
#1281
…
Main changes explained:
How to test:
npm installto run this PR locallynpm run test:verbose -- ./src/test/timeNotMetCoreTeamTest.test.jsScreenshots or videos of changes:
Note:
The time infrigenment assignemnt logic has issues in the current code so you can see all test cases where infringements are increased fail for this reason.
generateDescriptionForCoreTeam function is called but not defined so infringements are not assigned