This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
v18.2.2 #1409
Merged
v18.2.2 #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will handle most calls to the alerts.onebusaway.org/onebusaway.co service which do not depend on a specific region being available.
Service layer
Merge master
Upgrades to Swift 4.2
Not a 'proper' fix per se, but this will address issues where users who do not have a region assigned attempt to load data, which has been causing a crash in 18.2.1. ``` OBAMapDataLoader.m line 148: -[OBAMapDataLoader requestRegion:] OBAMapDataLoader.m line 210: -[OBAMapDataLoader requestTarget:] OBAMapDataLoader.m line 101: -[OBAMapDataLoader searchWithTarget:] OBAMapViewController.m line 755: -[OBAMapViewController refreshStopsInRegion] ```
Fixes crashing bug in map loader
* deletes first firebase account credentials * gitignores new location of firebase account credentials * loads other app-specific data out of a plist file
Adds a pair of properties to the NSUserActivity generated for stops that are necessary to enable Siri Shortcut support
Update analytics/fix Siri shortcuts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small release that fixes the biggest causes of crashing bugs in OneBusAway. It also helps ensure that Siri Shortcuts show up on your lock screen when they're supposed to.
Happy holidays!
Aaron