Repository navigation
feat(metrics): (#401) Add support for realtime trip counts matched in MetricsBean - #415
Merged
aaronbrethorst merged 2 commits intoMar 20, 2025
Merged
Conversation
|
|
aaronbrethorst
requested changes
Mar 12, 2025
aaronbrethorst
left a comment
aaronbrethorst
left a comment
Member
There was a problem hiding this comment.
please rebase against the latest changes in main and remove the excess whitespace from lines 39 and 55 of MetricsBeanServiceImpl
0xaboomar
force-pushed
the
feature/matched-trip-count
branch
from
March 13, 2025 02:55
a4bd772 to
7106184
Compare
Member
Author
|
@aaronbrethorst , I've resolved the merge conflicts and made the required changes. Looking forward to your review—please let me know if any further adjustments are needed. |
Member
|
@Abo-Omar-74 looks like you have a build failure! |
0xaboomar
force-pushed
the
feature/matched-trip-count
branch
from
March 14, 2025 03:13
6c9f11b to
a648f50
Compare
Member
Author
|
@aaronbrethorst , I have resolved it. The build error occurred because |
0xaboomar
force-pushed
the
feature/matched-trip-count
branch
from
March 16, 2025 00:29
a648f50 to
ef88a52
Compare
- Added a new field to store the count of realtime trips matched to scheduled trips on a per-agency basis. - Added getters and setters for the new field. - Organized the code to follow Java conventions. - Implemented to retrieve matched trip counts per agency. - Added getValidRealtimeTripIds() method to fetch valid real-time trip IDs based on agency and feed. - Updated populateRealtimeTripFields() method to populate matched trip counts in .
…nServiceImpl - Added necessary comments in MetricsBeanServiceImpl.java to document that getValidRealtimeTripIds was ported from onebusaway-watchdog-webapp.
0xaboomar
force-pushed
the
feature/matched-trip-count
branch
from
March 18, 2025 03:28
ef88a52 to
439d86d
Compare
aaronbrethorst
approved these changes
Mar 20, 2025
aaronbrethorst
left a comment
aaronbrethorst
left a comment
Member
There was a problem hiding this comment.
looks good! great work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for calculating and storing the count of real-time trips matched to scheduled trips on a per-agency basis in the
MetricsBean. This enhancement is part of the effort to extract code from theonebusaway-watchdog-webappmodule and move it intoonebusaway-transit-data-federationandonebusaway-api-webappto create a new, easier-to-use Metrics API.Resolves issue #401: Implement matched trip count in Metrics API.
Changes
MetricsBean.java
realtimeTripCountsMatchedto store the count of real-time trips matched to scheduled trips on a per-agency basis.MetricsBeanServiceImpl.java
populateRealtimeTripFields()method to populate therealtimeTripCountsMatchedfield inMetricsBean.getRealtimeTripCountsMatched()method to calculate the count of matched trips on a per-agency basis.getValidRealtimeTripIds()method to retrieve valid real-time trip IDs for a specified agency and optional feed.