Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 Merging this if statement with the enclosing one #8

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

AishwaryaShinde07
Copy link
Collaborator

This will decrease the nesting of the code and improve its readability.

Thanks for your contribution.

PLEASE REMOVE

To support us in providing a nice (and fast) open-source experience:

  1. Verify that the tests are passing
  2. Check that the code is properly formatted (using AndroidStudio's autoformatter)
  3. Provide write access to the branch
  4. If the PR is not ready for review, please submit it as a draft

PLEASE REMOVE

Describe the pull request
A clear and concise description of what the pull request changes/adds.

Link to the the issue
(If available): The link to the issue that this pull request solves.

License agreement
By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).

Note: new dependencies/libraries
Please refrain from introducing new libraries without consulting the team.

This will decrease the nesting of the code and improve its readability.
@AishwaryaShinde07 AishwaryaShinde07 changed the title Merging this if statement with the enclosing one #2 Merging this if statement with the enclosing one Feb 13, 2024
@AishwaryaShinde07 AishwaryaShinde07 merged commit ce08fd8 into main Feb 13, 2024
2 checks passed
@AishwaryaShinde07
Copy link
Collaborator Author

AishwaryaShinde07 commented Feb 13, 2024

Merged two if statements into one for better code organization and readability.

@AishwaryaShinde07
Copy link
Collaborator Author

PR Merged for issue: #6 (comment)

@OmniaAlam OmniaAlam added this to the Deliverable-1 milestone Feb 14, 2024
OmniaAlam pushed a commit that referenced this pull request Feb 16, 2024
Fixing nested if issue in TrackStatisticsUpdater
OmniaAlam pushed a commit that referenced this pull request Apr 2, 2024
Manually called Thread.interrupt() to re-interrupt the current thread.
OmniaAlam pushed a commit that referenced this pull request Apr 2, 2024
Issue #4 is solved by using a more specific exception, such as Unsupp…
rakibulhuda pushed a commit that referenced this pull request Apr 23, 2024
added structure and linked per day statistics page
rakibulhuda pushed a commit that referenced this pull request Apr 23, 2024
…nounce-avg-speed-at-end-of-each-recording

65 settings voice announcements announce avg speed at end of each recording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants