Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider subset match valid for symbol lookups and completions #990

Merged
merged 3 commits into from
Oct 26, 2017

Conversation

filipw
Copy link
Member

@filipw filipw commented Oct 25, 2017

Given the following code:

    public class Options { }
    public interface IConfigurationOptions { }
    public class ConfigurationOptions : IConfigurationOptions { }

When passing Opt into symbol lookup or completion service, we will only return Options, which is not the optimal user experience.
In fact, this is not in line with the Visual Studio behavior, where in both symbol lookup and completion, opt returns all 3 possibilities.

This PR changes a subset match of length longer than 1 to be valid when verifying symbol/completion subsequences, resulting in much better experience.

Copy link
Contributor

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Someday, we'll just want to do all of the matching we do in Roslyn, but this is simple enough to tweak and improve now.

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to add better fuzzy searching (Resharper like) but today this makes it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants