MSBuild Update #907
MSBuild Update #907
Conversation
build.json
Outdated
| "LegacyDotNetVersion": "1.0.0-preview2-1-003177", | ||
| "FutureDotNetVersion": "2.0.0-preview2-006497", |
There was a problem hiding this comment.
the range of supported versions is getting out of control 😀
build.cake
Outdated
| DeleteFile(CombinePaths(folder, "Microsoft.VisualBasic.Core.targets")); | ||
| DeleteFile(CombinePaths(folder, "VBCSCompiler.exe")); | ||
| DeleteFile(CombinePaths(folder, "VBCSCompiler.exe.config")); | ||
| DeleteFile(CombinePaths(folder, "csi.exe")); |
There was a problem hiding this comment.
it's not related to the PR, but it just occurred to me, can we keep these 3 csi files? it's only ~50kb I think
if they are there, they open a world of possibilities. we could add similar functionality into VS Code that already exists in VS - you can either execute CSX with a shortcut or highlight a piece of code and execute that. In VS it's done using the "C# Interactive Window" but csi.exe could be a simple replacement
There was a problem hiding this comment.
You already have APIs to execute scripts though.
There was a problem hiding this comment.
you mean to have such APIs built into OmniSharp? yes that would be possible, I remember discussing this with Jason some time ago.
it could also be a third party extension, I built one like that for scriptcs long time ago
But the simple way would be to just have CSI.exe as part of the bundle. The main reason is there is no distribution channel for CSI.exe at the moment other than installing MSBuild tools on your machine (and no distribution channel for non-Windows platforms at all), which is quite annoying
Again, this should be discussed separately, as it doesn't impact this PR, but it would be great to be able to simply ship CSI.exe with OmniSharp so that as a user you don't need to install anything else if you i.e. just want to start a C# REPL or something like that. The C# extension in VS Code could just facilitate shelling scripts into CSI (again, to simulate a bit the experience you have in VS with C# Interactive Window) and give folks an exploratory playground for C# straight up.
There was a problem hiding this comment.
No, I meant you have APIs to execute scripts from Roslyn.
I'm OK with leaving these. I'm just a little leery of supporting an execution path through "csi" here. Essentially, it would mean that we're supporting it. So long as we're willing to sign up for that... 😄
|
actually the test failures seem legit at the moment? |
|
Yeah, the test failures were me getting a bit greedy. I tried to add testing of .NET 2.0 SDKs at the very end , but it occurs to me that there's going to be problems with that until some upcoming Mono changes make their way in. I'll roll that bit back for now. |
…an initialize a VisualStudio BuildEnvironment
Two issues: 1. Now that we run the "Compile" target, files are generated during analysis. So, projects have more files in them. 2. We had projects that included glob patterns in them. Once the "Compile" target was run, those patterns *and* the implicit patterns were run, causing duplicate files in the projects.
DustinCampbell
force-pushed
the
use-compile-target
branch
from
c0396fd
to
07e7817
Compare
|
OK. CI passes now that I rolled back the 'future' testing stuff. @filipw: I went ahead and kept CSI.exe as well. |
This represents several updates for the OmniSharp MSBuild projects system:
Support for testing projects with the latest .NET Core SDK.