Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsSuggestionMode to AutoCompleteResponse for determining when the completion list should commit aggressively #882

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

DustinCampbell
Copy link
Contributor

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find!
I think SuggestionModeItem can have its own DisplayText, should that be forwarded to the caller too?

@DustinCampbell
Copy link
Contributor Author

The intention here is to able to determine when the completion list is in suggestion mode and shouldn't have define commit characters.

It's a bit heavy to add the values of SuggestionModeItem to every AutoCompleteResponse and I'm not sure how I'd even present that in VS Code. I'm working on a new '/completion' end point that we can use for future completion work that should marry a bit better with @david-driscoll's LSP work.

@filipw
Copy link
Member

filipw commented Jun 2, 2017

👍👍

@DustinCampbell
Copy link
Contributor Author

Thanks!

@DustinCampbell DustinCampbell merged commit 10ded38 into OmniSharp:dev Jun 2, 2017
@DustinCampbell DustinCampbell deleted the suggestion-mode branch August 30, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants