Prefix OmniSharp-specific configuration environment variables with "OMNISHARP_" #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
May 25, 2017
There was a problem hiding this comment.
👍
Yes, this is a breaking change, but I think it's a good one. Honestly, I doubt many are doing this today and it fixes weird problems when people have environment variables set for things like "msbuild". Once this goes in, we'll want to update the Configuration Options wiki page as well.
david-driscoll
approved these changes
May 25, 2017
|
update the branch for ci. |
|
thanks - I updated the wiki https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but of - I believe - small impact because it's very much a power feature to feed configuration into OmniSharp via environment variables (pretty much all current use cases would be via
omnisharp.jsonor command line arguments).However, we still allow to override any of the configuration via environment variables.
Because we didn't prefix OmniSharp specific env variables, it can lead to unexpected results like dotnet/vscode-csharp#1512.
This PR requires that OmniSharp uses for configuration only environment variables following this format:
OMNISHARP_{name}.Fixes dotnet/vscode-csharp#1512.