Update Roslyn to 4.13.0-1.24477.2 #2642
Draft
+35
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Oct 1, 2024
| @@ -47,7 +45,7 @@ protected OmniSharpTestHost CreateMSBuildTestHost(string path, IEnumerable<Expor | |||
| IConfiguration configurationData = null) | |||
| { | |||
| var environment = new OmniSharpEnvironment(path, logLevel: LogLevel.Trace); | |||
| var serviceProvider = TestServiceProvider.Create(this.TestOutput, environment, this.LoggerFactory, _assemblyLoader, _analyzerAssemblyLoader, _msbuildLocator, | |||
| var serviceProvider = TestServiceProvider.Create(this.TestOutput, environment, this.LoggerFactory, _assemblyLoader, ShadowCopyAnalyzerAssemblyLoader.CreateShadowCopyLoader(), _msbuildLocator, | |||
There was a problem hiding this comment.
We can no longer use one assembly loader for all the test runs because it now gets disposed with the other test services. See dotnet/roslyn#74845
JoeRobich
commented
Oct 1, 2024
| @@ -87,7 +87,7 @@ public static IServiceProvider Create( | |||
| var configuration = CreateConfiguration(configurationData); | |||
| var msbuildLocator = CreateMSBuildLocator(loggerFactory, assemblyLoader, configurationData); | |||
| var sharedTextWriter = CreateSharedTextWriter(testOutput); | |||
| var analyzerAssemblyLoader = ShadowCopyAnalyzerAssemblyLoader.Instance; | |||
| var analyzerAssemblyLoader = ShadowCopyAnalyzerAssemblyLoader.CreateShadowCopyLoader(); | |||
There was a problem hiding this comment.
Another case where tests cannot share the same assembly loader.
JoeRobich
commented
Oct 1, 2024
| @@ -120,7 +120,7 @@ private async Task VerifyImplementType(string code, string expectedChange, Dicti | |||
| Column = point.Offset, | |||
| FileName = testFile.FileName, | |||
| Buffer = testFile.Content.Code, | |||
| Identifier = "False;False;True:global::IFoo;AssemblyName;Microsoft.CodeAnalysis.ImplementInterface.AbstractImplementInterfaceService+ImplementInterfaceCodeAction;", | |||
| Identifier = "False;False;True:global::IFoo;Microsoft.CodeAnalysis.ImplementInterface.AbstractImplementInterfaceService+ImplementInterfaceCodeAction;", | |||
There was a problem hiding this comment.
Assembly Name removed in dotnet/roslyn@9c8c21f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.