Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Cake bits in .NET 6 builds #2455

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Include Cake bits in .NET 6 builds #2455

merged 3 commits into from
Oct 5, 2022

Conversation

bjorkstromm
Copy link
Member

Seems we forgot to remove the TFM check on project reference for Cake after .NET 6 support was added.

333fred
333fred reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for the tests to pass before approving. IIRC, cake was disabled because of failing tests.

@bjorkstromm
Copy link
Member Author

I'll wait for the tests to pass before approving. IIRC, cake was disabled because of failing tests.

They have been enabled for quite some while :) But I forgot to remove the TFM check:
#2307

filipw
filipw approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devlead
devlead approved these changes Oct 5, 2022
View reviewed changes
Copy link

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bjorkstromm bjorkstromm merged commit dd24a60 into OmniSharp:master Oct 5, 2022
@bjorkstromm bjorkstromm deleted the feature/include-cake-bits branch October 5, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@filipw filipw filipw approved these changes

@devlead devlead devlead approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorkstromm @JoeRobich @devlead @filipw @333fred