Move LSP Completion to the new CompletionService #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit overdue, but as vscode will hopefully be moving to the LSP shortly, we can look at starting to convert its providers over to the LSP. As the new service was designed to be a mirror of LSP, this simplifies the implementation of the handler: just convert the request to the internal one, pass through, and convert the internal result back to LSP's version. As part of this, I ported all of the completion tests in the regular service to the LSP, with only a few small changes around host setup and where names/nesting differed a bit from the LSP.
|
Hmm, getting cancellations I wasn't getting locally. Will have a look tonight. |
|
as discussed on Slack - this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit overdue, but as vscode will hopefully be moving to the LSP shortly, we can look at starting to convert its providers over to the LSP. As the new service was designed to be a mirror of LSP, this simplifies the implementation of the handler: just convert the request to the internal one, pass through, and convert the internal result back to LSP's version. As part of this, I ported all of the completion tests in the regular service to the LSP, with only a few small changes around host setup and where names/nesting differed a bit from the LSP.