Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build NetCoreApp2.1 test project with .NET Core SDK 2.1 #2040

Merged
merged 5 commits into from
Dec 15, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Dec 14, 2020

To ensure changes to our build tools dependencies (such as #2034) do not break compatibility with NET Core 2.1 SDK while it is LTS, this PR builds the NetCore21Project test project with a 2.1 SDK.

@JoeRobich
Copy link
Member Author

@filipw @mholo65 @david-driscoll please take a look

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable to me

@JoeRobich JoeRobich merged commit e743a5e into OmniSharp:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants