Targeted DiagnosticWorker Revert #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yze a specific document directly and skip the cache.
333fred
force-pushed
the
revert-caching-changes
branch
from
5cc02a9
to
50be0e6
Compare
filipw
approved these changes
Oct 14, 2020
|
I ran this locally and it indeed doesn't have the perf hit anymore 👏 IMHO should be merged and released ASAP |
|
|
JoeRobich
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1983, fix #1982, and fix dotnet/vscode-csharp#4111. I reverted the diagnostic worker change, and introduced a separate codepath for FixAll to use when calculating updated diagnostics. For easier review I broke this into 2 changes: