Update included Mono to 6.12.0 #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
update-mono-6.12.0
branch
2 times, most recently
from
b34d2a2
to
b0dffa7
Compare
JoeRobich
force-pushed
the
update-mono-6.12.0
branch
from
b0dffa7
to
9d76176
Compare
|
that's great news! because last time I checked out 6.12 preview it still had msbuild 16.6 |
filipw
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw 6.12.0 was listed for download as stable.
Also, noticed that the 6.12.0 Mono ships with a 16.8 MSBuild meaning we can revert the meaning of
omnisharp.useGlobalMonowhen we take the next release. Verified that the 6.12 Mono's MSBuild handles loading the dotnet/sdk sdk.sln which is firmly .NET 5. =)[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator Located 2 MSBuild instance(s) ! 1: Mono 16.8.0 - "/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin" 2: StandAlone 16.8.0 - "/Users/joeyrobichaud/.vscode-insiders/extensions/ms-dotnettools.csharp-1.23.3/.omnisharp/1.37.1/omnisharp/.msbuild/Current/Bin"