Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote config_file in Mono ENV Options #1979

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Quote config_file in Mono ENV Options #1979

merged 1 commit into from
Oct 12, 2020

Conversation

bjorkstromm
Copy link
Member

This should fix an issue when there's a space in the path where OmniSharp is installed.

This should fix an issue when there's a space in the path where OmniSharp is installed.
@bjorkstromm
Copy link
Member Author

Copy link

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have verified this locally - solved my issue. Thank you!

@filipw filipw merged commit 36ea769 into master Oct 12, 2020
@filipw filipw deleted the mholo65-patch-1 branch October 12, 2020 12:44
@henryju
Copy link
Contributor

henryju commented Jun 9, 2021

Hello, I'm affected by the same bug. It seems that even latest release (v1.37.10) still doesn't contain the fix. How is it possible?
You can download https://github.com/OmniSharp/omnisharp-roslyn/releases/download/v1.37.10/omnisharp-linux-x64.zip and open the run file, and the content is:
export MONO_ENV_OPTIONS="--assembly-loader=strict --config ${config_file}"

henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 9, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 9, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 11, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 11, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 14, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 14, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 15, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 21, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 23, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 25, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 29, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jun 30, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 1, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 2, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 2, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 8, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 9, 2021
henryju added a commit to SonarSource/sonarlint-intellij that referenced this pull request Jul 12, 2021
@henryju
Copy link
Contributor

henryju commented Oct 26, 2021

Still not fixed in https://github.com/OmniSharp/omnisharp-roslyn/releases/download/v1.37.16/omnisharp-linux-x64.zip. Are you rebuilding the mono package at every release?

@JoeRobich
Copy link
Member

@henryju I've opened #2256 to resolve this. Sorry I didn't realize we weren't already packaging the latest with each build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants