always log error responses with error level #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment an exception from an endpoint is only logged when debug level is enabled.
This leads to quite frustrating troubleshooting situations - when people experience errors on e.g. completion or code actions normally their log doesn't show any errors, until they enable debug level. On debug level, on the other hand, there is a ton of logs produced though, so often the error gets cropped anyway as it's tedious to copy the massive log stack.
This change adds automatic logging of unsuccessful (errored) endpoint responses at error level.
This guarantees that any exceptions are automatically visible even at default logging level.