Better handle completion when the display text is not in the final result #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult Override and partial method completion can have scenarios where the DisplayText of the completion item does not appear in the final text, such as when types need to be imported or when nullability differs between original declaration and generation declaration sites. We now handle these by parsing the change if we fail to find the insertion text, and using the last method in the change to find the correct location in the new text. Fixes OmniSharp#1907.
filipw
approved these changes
Aug 22, 2020
bjorkstromm
approved these changes
Aug 22, 2020
| @@ -23,7 +23,7 @@ public class CompletionItem | |||
| /// <summary> | |||
| /// Tags for this completion item | |||
| /// </summary> | |||
| public ImmutableArray<CompletionItemTag>? Tags { get; set; } | |||
| public IReadOnlyList<CompletionItemTag>? Tags { get; set; } | |||
There was a problem hiding this comment.
Normally, I'd be hesitant introducing breaking changes in Abstractions (since we ship NuGet packages of this). But this is a quite new API, so it's cool 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override and partial method completion can have scenarios where the DisplayText of the completion item does not appear in the final text, such as when types need to be imported or when nullability differs between original declaration and generation declaration sites. We now handle these by parsing the change if we fail to find the insertion text, and using the last method in the change to find the correct location in the new text. Fixes #1907.