Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roslyn version and tooling to better match NET 5 Preview8 #1897

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Update Roslyn version and tooling to better match NET 5 Preview8 #1897

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb8ffbc
Update Roslyn version and tooling to match NET 5 Preview8
JoeRobich Aug 18, 2020
92c81fd
Update changelog for 1.36.2 release
JoeRobich Aug 18, 2020
ba759e4
Merge branch 'master' into update-roslyn
JoeRobich Aug 18, 2020
f512ce2
Update changelog to reflect 1.37.0 release version
JoeRobich Aug 18, 2020
49ad1b4
Revert Roslyn version bump
JoeRobich Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Changelog
All changes to the project will be documented in this file.

## [1.36.2] - 2020-08-18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it has completion service, maybe 1.37.0?

* Update Roslyn version and tooling to match .NET 5 Preview8 (PR: [#1897](https://github.com/OmniSharp/omnisharp-roslyn/pull/1897))
* Updated lsp library to fix issue with signature help, etc (PR: [#1890](https://github.com/OmniSharp/omnisharp-roslyn/pull/1890))
* Include version matched target files with minimal MSBuild (PR: [#1895](https://github.com/OmniSharp/omnisharp-roslyn/pull/1895))
* Fix lack of trailing italics in quickinfo (PR: [#1894](https://github.com/OmniSharp/omnisharp-roslyn/pull/1894))
* Added System.Reflection.Emit.* to embedded mono script (PR: [#1892](https://github.com/OmniSharp/omnisharp-roslyn/pull/1892))
* Start moving omnisharp to directly using Roslyn's completion service (PR: [#1877](https://github.com/OmniSharp/omnisharp-roslyn/pull/1877))
* Add asynchronous test completed events (PR: [#1802](https://github.com/OmniSharp/omnisharp-roslyn/pull/1802))

## [1.36.1] - 2020-08-12
* Fix MSBuild version mismatch with new SDKs ([omnisharp-vscode#3951](https://github.com/OmniSharp/omnisharp-vscode/issues/3951), PR: [#1883](https://github.com/OmniSharp/omnisharp-roslyn/pull/1883))

Expand Down
2 changes: 1 addition & 1 deletion build/Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<MSBuildPackageVersion>16.6.0</MSBuildPackageVersion>
<NuGetPackageVersion>5.2.0</NuGetPackageVersion>
<RoslynPackageVersion>3.8.0-1.20363.1</RoslynPackageVersion>
<RoslynPackageVersion>3.8.0-2.20413.3</RoslynPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from where do you take the exact version? from https://github.com/dotnet/versions/tree/master/build-info/dotnet/roslyn? I normally go there but I wonder if there is a better place

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I am taking it from the sdk, https://github.com/dotnet/sdk/blob/release/5.0.1xx-preview8/eng/Versions.props#L115, but development builds are published to AzDO as well https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet-tools&package=Microsoft.Net.Compilers.Toolset&version=3.8.0-3.20418.5&protocolType=NuGet&view=versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I did not know about dotnet/versions. That is super useful. =)

<XunitPackageVersion>2.4.0</XunitPackageVersion>
</PropertyGroup>

Expand Down
40 changes: 20 additions & 20 deletions tools/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,27 @@
<packages>
<package id="Cake" version="0.37.0" />
<package id="Microsoft.Bcl.AsyncInterfaces" version="1.1.1" />
<package id="Microsoft.Build" version="16.8.0-preview-20371-01" />
<package id="Microsoft.Build.Framework" version="16.8.0-preview-20371-01" />
<package id="Microsoft.Build.Runtime" version="16.8.0-preview-20371-01" />
<package id="Microsoft.Build.Tasks.Core" version="16.8.0-preview-20371-01" />
<package id="Microsoft.Build.Utilities.Core" version="16.8.0-preview-20371-01" />
<package id="Microsoft.Net.Compilers.Toolset" version="3.8.0-1.20373.6" />
<package id="Microsoft.DotNet.MSBuildSdkResolver" version="5.0.100-preview.8.20362.1" />
<package id="Microsoft.Build.NuGetSdkResolver" version="5.8.0-preview.1.6718" />
<package id="Microsoft.Build" version="16.8.0-preview-20417-01" />
<package id="Microsoft.Build.Framework" version="16.8.0-preview-20417-01" />
<package id="Microsoft.Build.Runtime" version="16.8.0-preview-20417-01" />
<package id="Microsoft.Build.Tasks.Core" version="16.8.0-preview-20417-01" />
<package id="Microsoft.Build.Utilities.Core" version="16.8.0-preview-20417-01" />
<package id="Microsoft.Net.Compilers.Toolset" version="3.8.0-2.20413.3" />
<package id="Microsoft.DotNet.MSBuildSdkResolver" version="5.0.100-preview.8.20362.2" />
<package id="Microsoft.Build.NuGetSdkResolver" version="5.8.0-preview.2.6776" />
<package id="Newtonsoft.Json" version="12.0.2" />
<package id="NuGet.Build.Tasks" version="5.8.0-preview.1.6718" />
<package id="NuGet.Commands" version="5.8.0-preview.1.6718" />
<package id="NuGet.Common" version="5.8.0-preview.1.6718" />
<package id="NuGet.Configuration" version="5.8.0-preview.1.6718" />
<package id="NuGet.Credentials" version="5.8.0-preview.1.6718" />
<package id="NuGet.DependencyResolver.Core" version="5.8.0-preview.1.6718" />
<package id="NuGet.Frameworks" version="5.8.0-preview.1.6718" />
<package id="NuGet.LibraryModel" version="5.8.0-preview.1.6718" />
<package id="NuGet.Packaging" version="5.8.0-preview.1.6718" />
<package id="NuGet.ProjectModel" version="5.8.0-preview.1.6718" />
<package id="NuGet.Protocol" version="5.8.0-preview.1.6718" />
<package id="NuGet.Versioning" version="5.8.0-preview.1.6718" />
<package id="NuGet.Build.Tasks" version="5.8.0-preview.2.6776" />
<package id="NuGet.Commands" version="5.8.0-preview.2.6776" />
<package id="NuGet.Common" version="5.8.0-preview.2.6776" />
<package id="NuGet.Configuration" version="5.8.0-preview.2.6776" />
<package id="NuGet.Credentials" version="5.8.0-preview.2.6776" />
<package id="NuGet.DependencyResolver.Core" version="5.8.0-preview.2.6776" />
<package id="NuGet.Frameworks" version="5.8.0-preview.2.6776" />
<package id="NuGet.LibraryModel" version="5.8.0-preview.2.6776" />
<package id="NuGet.Packaging" version="5.8.0-preview.2.6776" />
<package id="NuGet.ProjectModel" version="5.8.0-preview.2.6776" />
<package id="NuGet.Protocol" version="5.8.0-preview.2.6776" />
<package id="NuGet.Versioning" version="5.8.0-preview.2.6776" />
<package id="runtime.linux-x64.Microsoft.NETCore.DotNetHostResolver" version="5.0.0-preview.8.20361.2" />
<package id="runtime.osx-x64.Microsoft.NETCore.DotNetHostResolver" version="5.0.0-preview.8.20361.2" />
<package id="runtime.win-x64.Microsoft.NETCore.DotNetHostResolver" version="5.0.0-preview.8.20361.2" />
Expand Down