Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Hover LSP provider to use the new quickinfo service #1870

Merged
merged 7 commits into from
Aug 2, 2020

Conversation

333fred
Copy link
Contributor

@333fred 333fred commented Jul 29, 2020

@david-driscoll this does what it says on the tin. Hopefully this will be another thing that we can get working in vscode. I'm unsure what the Range in LSP represents here, though: is it supposed to be full range of the thing being hovered over? If so, I'm not sure if we actually want to implement that: I'm used to highlighting either getting every instance of a thing, or not highlighting it at all. If we do want to implement that, though, it would be very straightforward to add, as QuickInfo already has the info.

Fixes #1806.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@david-driscoll
Copy link
Member

Thanks @333fred

@david-driscoll david-driscoll merged commit 52621cb into OmniSharp:master Aug 2, 2020
@333fred 333fred deleted the hover-lsp branch August 2, 2020 22:17
@bstaletic
Copy link

bstaletic commented Aug 13, 2024

I'm migrating my client to use LSP with OmniSharp-Roslyn.
I would have expected textDocument/hover to provide a docstring and type if available.
That used to be the case with the TypeLookupRequest.
Now, with the QuickInfoRequest, I am only getting the type information.
How are LSP clients supposed to get docstrings?

EDIT:

Ah, just figured it out!
Previously, these comments were considered:

                /// an integer, or something
                private int an_int;

But now the docstring has to be wrapped in <summary>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP - Support inheritdoc
5 participants