Update Roslyn version and tools to match .NET 5 Preview8 #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
approved these changes
Jul 27, 2020
|
Versions taken from https://github.com/dotnet/sdk/blob/release/5.0.1xx-preview8/eng/Versions.props, although it can be a moving target. |
|
I will need to update the SDK to a published version. |
JoeRobich
force-pushed
the
update-versions-net5p8
branch
from
553d3e8
to
b8c0e77
Compare
|
Going to revert changing the SDK we use in out tests. Will perform manual validation of this build with NET 5 preview 8. We can update the version after it is released instead of relying on a nightly. |
JoeRobich
force-pushed
the
update-versions-net5p8
branch
from
0b293ae
to
c8d5a21
Compare
|
Had to revert to an earlier build of Roslyn. These tests caught a regression in |
|
good test then 🥁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether we would want the included build tools to match the .NET SDK tools or the latest VS preview tools.