Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces a new hover provider, under V2 of the protocol, that uses Roslyn's QuickInfoService #1860

Merged
merged 6 commits into from
Jul 25, 2020

Commits on Jul 24, 2020

  1. Updated .NET SDK.

    333fred committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    af15858 View commit details
    Browse the repository at this point in the history
  2. Introduces a new hover provider, under V2 of the protocol, that uses …

    …Roslyn's QuickInfoService
    
    The existing provider uses a custom handler, which this replaces. Among other benefits, this brings nullability display when available, and ensures that any new additions to roslyn's info get propagated to users of this service. Unfortunately, however, TaggedText in VS is significantly more powerful than vscode's hover renderer: that simply uses markdown. Their implementation does not support any extensions to enable C# formatting of code inline, I created a poor-man's substitute: for the description line, we treat the whole line as C#. It does mean there can be a bit of odd formatting with `(parameter)` or similar, but this exactly mirrors what typescript does so I don't think it's a big deal. For other sections, I picked sections that looked ok when formatted as C# code, and I otherwise did a simple conversion, as best I could, from tagged text to inline markdown.
    333fred committed Jul 24, 2020
    3 Configuration menu
    Copy the full SHA
    017a909 View commit details
    Browse the repository at this point in the history
  3. PR Feedback

    Rewrite quickinfo loop to be fully iterative and not create closures.
    Moved the new service to V1.
    Simplify the output.
    333fred committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    2794241 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. Simplify the API by sending a pre-markdowned string, rather than send…

    …ing parts that the client needs to reassemble themselves.
    333fred committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    8d0dbc4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4682884 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f51549f View commit details
    Browse the repository at this point in the history