Added support for "sync namespace" refactoring #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
approved these changes
Jul 19, 2019
| } | ||
| else | ||
| { | ||
| base.ApplyProjectChanges(projectChanges); |
There was a problem hiding this comment.
Should we call the base ApplyProjectChanges all the time or only if the namespace didn't change? Would this possibly miss some changes if they were batched together with the namespace change?
There was a problem hiding this comment.
thanks @david-driscoll this is a great catch - changed accordingly 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1475
Demo (first from within a folder, and then from the root of the project):
We have actually PR-ed into Roslyn a change that opened up the necessary APIs to public dotnet/roslyn#35486 to make it work.
This PR introduces a bump to Roslyn
3.3.0-beta1-19365-07to have access to them - this is a build for thedev16.3release train.We also now track "folders" of the documents added to the workspace (the refactoring works off that) - which is basically a relative path.
Default namespace is, by default, the assembly name, unless overwritten by
<RootNamespace>MsBuild property. A change in MsBuild project file is respected by us in real time (no need to restart OmniSharp), by updating the workspace accordingly. Unfortunately there is still a bug in Roslyn where the default namespace change doesn't propagate correctly viaTryApplyChangeson the solution, so we have a small reflection workaround for that. I will PR the necessary change into Roslyn and once it's available we can remove the workaround.cc @savpek